feat: add upgradeability to ProposalValidator contract #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lidator-upgradeability-2 Signed-off-by: Chiin <[email protected]>
0xOneTony
reviewed
May 23, 2025
| /// @notice The ProposalValidator contract is responsible for validating proposals and moving | ||
| /// them to the vote phase on the Optimism Governor. | ||
| contract ProposalValidator is Ownable { | ||
| contract ProposalValidator is OwnableUpgradeable { |
Member
There was a problem hiding this comment.
i thought about this, maybe we should follow what OP is doing with their other contracts and use ReinitializableBase and ISemver
0xChin
force-pushed
the
feat/proposal-validator-upgradeability-2
branch
from
7691cd1 to
407a012
Compare
0xOneTony
pushed a commit
that referenced
this pull request
Jul 29, 2025
* feat: add upgradeability to ProposalValidator contract * chore: fix styling * docs: use correct natspec in ProosalValidator contract * feat: add semver * feat: add reinitializable base --------- Signed-off-by: Chiin <[email protected]>
0xOneTony
pushed a commit
that referenced
this pull request
Jul 29, 2025
* feat: add upgradeability to ProposalValidator contract * chore: fix styling * docs: use correct natspec in ProosalValidator contract * feat: add semver * feat: add reinitializable base --------- Signed-off-by: Chiin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes OPT-777