feat: benchmarking script by xorsal · Pull Request #63 · defi-wonderland/aztec-standards

xorsal · 2025-03-21T12:41:34Z

No description provided.

- change `U128` to `u128` - use u128 operations - use `PartialUintNote` instead of `Field` for hiding points

- use `u128` instead of `U128`

Skipped two tests because I'm unable to understand what seems to be the problem with them

Solves #34 by unconstraining the library method (it gets constrained anyways because its being executed from a constrained method)

`Assertion failed: unauthorized 'true, authorized'` I changed the test a bit, but I don't really understand what seems to be the problem

we don't care about their gate-counting measurements but we will use them to measure gas later!

github-actions · 2025-04-24T18:19:41Z

Benchmark Comparison

Comparison Threshold: 5%

Legends: 🟢 Improvement | 🔴 Regression | ⚪ No significant change | 🆕 New | 🚮 Removed

Contract: token_contract

	Function	Gates			DA Gas			L2 Gas
Status		Base	PR	Diff	Base	PR	Diff	Base	PR	Diff
⚪	`BENCHMARK_RUNNER_ERROR`	0	0	-	0	0	-	0	0	-

github-actions · 2025-04-25T09:26:28Z

Benchmark Comparison

Comparison Threshold: 5%

Legends: 🟢 Improvement | 🔴 Regression | ⚪ No significant change | 🆕 New | 🚮 Removed

Contract: token_contract

	Function	Gates			DA Gas			L2 Gas
Status		Base	PR	Diff	Base	PR	Diff	Base	PR	Diff
⚪	`BENCHMARK_RUNNER_ERROR`	0	0	-	0	0	-	0	0	-

github-actions · 2025-04-25T09:41:53Z

Benchmark Comparison

Comparison Threshold: 5%

Legends: 🟢 Improvement | 🔴 Regression | ⚪ No significant change | 🆕 New | 🚮 Removed

Contract: token_contract

	Function	Gates			DA Gas			L2 Gas
Status		Base	PR	Diff	Base	PR	Diff	Base	PR	Diff
⚪	`BENCHMARK_RUNNER_ERROR`	0	0	-	0	0	-	0	0	-

github-actions · 2025-04-30T10:16:54Z

Benchmark Comparison

Contract: token

	Function	Gates			DA Gas			L2 Gas
Status		Base	PR	Diff	Base	PR	Diff	Base	PR	Diff
⚪	`burn_private`	325,168	325,168		13,517	13,517		53,473	53,473
⚪	`burn_public`	208,476	208,476		2,253	2,253		71,090	71,090
⚪	`mint_to_private`	320,811	320,811		12,954	12,954		47,489	47,489
⚪	`mint_to_public`	208,476	208,476		2,253	2,253		71,866	71,866
⚪	`transfer_private_to_private`	331,983	331,983		24,218	24,218		20,909	20,909
⚪	`transfer_private_to_public`	325,248	325,248		13,517	13,517		70,435	70,435
⚪	`transfer_private_to_public_with_commitment`	350,224	350,224		24,781	24,781		104,237	104,237
⚪	`transfer_public_to_private`	316,576	316,576		12,954	12,954		64,609	64,609
⚪	`transfer_public_to_public`	208,476	208,476		2,253	2,253		88,498	88,498

github-actions · 2025-04-30T10:27:12Z

Benchmark Comparison

Contract: token

	Function	Gates			DA Gas			L2 Gas
Status		Base	PR	Diff	Base	PR	Diff	Base	PR	Diff
⚪	`burn_private`	325,168	325,168		13,517	13,517		53,473	53,473
⚪	`burn_public`	208,476	208,476		2,253	2,253		71,090	71,090
⚪	`mint_to_private`	320,811	320,811		12,954	12,954		47,489	47,489
⚪	`mint_to_public`	208,476	208,476		2,253	2,253		71,866	71,866
⚪	`transfer_private_to_private`	331,983	331,983		24,218	24,218		20,909	20,909
⚪	`transfer_private_to_public`	325,248	325,248		13,517	13,517		70,435	70,435
⚪	`transfer_private_to_public_with_commitment`	350,224	350,224		24,781	24,781		104,237	104,237
⚪	`transfer_public_to_private`	316,576	316,576		12,954	12,954		64,609	64,609
⚪	`transfer_public_to_public`	208,476	208,476		2,253	2,253		88,498	88,498

github-actions · 2025-04-30T10:39:42Z

Benchmark Comparison

Contract: token

	Function	Gates			DA Gas			L2 Gas
Status		Base	PR	Diff	Base	PR	Diff	Base	PR	Diff
⚪	`burn_private`	325,168	325,168		13,517	13,517		53,473	53,473
⚪	`burn_public`	208,476	208,476		2,253	2,253		71,090	71,090
⚪	`mint_to_private`	320,811	320,811		12,954	12,954		47,489	47,489
⚪	`mint_to_public`	208,476	208,476		2,253	2,253		71,866	71,866
⚪	`transfer_private_to_private`	331,983	331,983		24,218	24,218		20,909	20,909
⚪	`transfer_private_to_public`	325,248	325,248		13,517	13,517		70,435	70,435
⚪	`transfer_private_to_public_with_commitment`	350,224	350,224		24,781	24,781		104,237	104,237
⚪	`transfer_public_to_private`	316,576	316,576		12,954	12,954		64,609	64,609
⚪	`transfer_public_to_public`	208,476	208,476		2,253	2,253		88,498	88,498

github-actions · 2025-04-30T10:51:07Z

Benchmark Comparison

Contract: token

	Function	Gates			DA Gas			L2 Gas
Status		Base	PR	Diff	Base	PR	Diff	Base	PR	Diff
⚪	`burn_private`	325,168	325,168		13,517	13,517		53,473	53,473
⚪	`burn_public`	208,476	208,476		2,253	2,253		71,090	71,090
⚪	`mint_to_private`	320,811	320,811		12,954	12,954		47,489	47,489
⚪	`mint_to_public`	208,476	208,476		2,253	2,253		71,866	71,866
⚪	`transfer_private_to_private`	331,983	331,983		24,218	24,218		20,909	20,909
⚪	`transfer_private_to_public`	325,248	325,248		13,517	13,517		70,435	70,435
⚪	`transfer_private_to_public_with_commitment`	350,224	350,224		24,781	24,781		104,237	104,237
⚪	`transfer_public_to_private`	316,576	316,576		12,954	12,954		64,609	64,609
⚪	`transfer_public_to_public`	208,476	208,476		2,253	2,253		88,498	88,498

0xmoebius · 2025-05-01T11:38:11Z

replaced by #85

xorsal and others added 29 commits March 20, 2025 08:34

fix: husky precommit

c3ab605

feat: upgrade to v81

1161af6

feat: use new partial note impl

cc283f7

feat: update libs

dabd625

feat: update Token contract

00317f1

- change `U128` to `u128` - use u128 operations - use `PartialUintNote` instead of `Field` for hiding points

test: update tests

6cb0219

- use `u128` instead of `U128`

chore: fmt

4a1bbfc

test: update tests

080fd0d

Skipped two tests because I'm unable to understand what seems to be the problem with them

test: use deployFundedSchnorrAccounts instead of createAccount

726b655

fix: unconstraining authwit lib method (#62)

65dc77d

Solves #34 by unconstraining the library method (it gets constrained anyways because its being executed from a constrained method)

test: use getInitialTestAccountsWallets

4f566f2

test: uint notes values now have a different order

27b1d5f

test: skip public transfer with authwith

c875497

`Assertion failed: unauthorized 'true, authorized'` I changed the test a bit, but I don't really understand what seems to be the problem

chore: replace "partial notes" and "hiding point" with "commitment"

0258ec4

chore: delete address note

a6103ef

chore: upgrade to v0.82.1

99fe27a

chore: remove uint-note

a142a43

chore: use aztec-packages uint-note

afc10f6

chore: ugprade to v0.82.2

d7da08b

test: update tests

8f4173f

test: update ts tests to the newer Wallet interface

299f75b

ci: temporary disable TS tests in workflow

45f0e02

test: add benchmarking script

f770bdd

chore: add @aztec/stdlib and tsx

fc11f88

test: move token deploy functions to utils

a37467c

chore: use correct token contract artifact

7e35007

feat: add bash script to use aztec-wallet profile

27c0b69

feat: comment non-private functions

0ca84ce

we don't care about their gate-counting measurements but we will use them to measure gas later!

ci: run bench and display

eae456f

xorsal force-pushed the feat/benchmarking-script branch from cabaa7c to eae456f Compare March 25, 2025 15:48

0xmoebius and others added 6 commits April 24, 2025 15:06

fix: debugging action

ed89917

fix: debugging action

b5def21

fix: debugging action

10e8d9d

fix: debugging action

fdc6ef0

fix: debugging action

af33979

fix: debugging action

2eb555d

fix: trigger ci

7c57e32

fix: trigger ci

34731b0

0xmoebius added 10 commits April 25, 2025 11:49

fix: trigger ci

92c0408

fix: dont run tests for now

295ece4

fix: trigger ci

634dcbe

fix: refactor action

9dbcbaa

fix: action path

f56726e

fix: action path

d51a812

fix: trigger new action branch

ae5b7eb

fix: trigger ci

7d52d97

fix: install published package

31d3ec2

fix: new ver

748098e

fix: move to dev dep

3489576

fix: import path

cbcfd0a

fix: remove latest benchmark

f7bbe38

0xmoebius closed this May 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: benchmarking script#63

feat: benchmarking script#63
xorsal wants to merge 65 commits intodevfrom
feat/benchmarking-script

xorsal commented Mar 21, 2025

Uh oh!

github-actions bot commented Apr 24, 2025

Uh oh!

github-actions bot commented Apr 25, 2025

Uh oh!

github-actions bot commented Apr 25, 2025

Uh oh!

github-actions bot commented Apr 30, 2025

Uh oh!

github-actions bot commented Apr 30, 2025

Uh oh!

github-actions bot commented Apr 30, 2025

Uh oh!

github-actions bot commented Apr 30, 2025

Uh oh!

0xmoebius commented May 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

xorsal commented Mar 21, 2025

Uh oh!

github-actions bot commented Apr 24, 2025

Benchmark Comparison

Contract: token_contract

Uh oh!

github-actions bot commented Apr 25, 2025

Benchmark Comparison

Contract: token_contract

Uh oh!

github-actions bot commented Apr 25, 2025

Benchmark Comparison

Contract: token_contract

Uh oh!

github-actions bot commented Apr 30, 2025

Benchmark Comparison

Contract: token

Uh oh!

github-actions bot commented Apr 30, 2025

Benchmark Comparison

Contract: token

Uh oh!

github-actions bot commented Apr 30, 2025

Benchmark Comparison

Contract: token

Uh oh!

github-actions bot commented Apr 30, 2025

Benchmark Comparison

Contract: token

Uh oh!

0xmoebius commented May 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants