Skip to content

feat: arc-403 scaffolding#297

Draft
wei3erHase wants to merge 5 commits intodevfrom
feat/arc-403
Draft

feat: arc-403 scaffolding#297
wei3erHase wants to merge 5 commits intodevfrom
feat/arc-403

Conversation

@wei3erHase
Copy link
Copy Markdown
Member

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 5, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 7265a6ea-e9b9-4f91-bddd-7814e8bd2128

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/arc-403

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 5, 2026

Benchmark Comparison

CPU Cores RAM Arch
AMD EPYC 7763 64-Core Processor 16 63 GiB x64

Contract: escrow

Function Gates DA Gas L2 Gas Proving Time (ms)
Status Base PR Diff Base PR Diff Base PR Diff Base PR Diff
(partial) withdraw 538,526 546,255 +7,729 (+1.4%) 1,312 1,312 512 512 7,281 7,034 -247 (-3.4%)
withdraw 538,526 546,255 +7,729 (+1.4%) 736 736 512 512 7,215 7,052 -163 (-2.3%)
withdraw_nft 516,039 516,039 736 736 512 512 7,102 6,878 -224 (-3.2%)

Contract: logic

Function Gates DA Gas L2 Gas Proving Time (ms)
Status Base PR Diff Base PR Diff Base PR Diff Base PR Diff
get_escrow 519,275 519,275 128 128 512 512 7,077 6,860 -217 (-3.1%)
secret_key_to_public_keys 514,355 514,355 128 128 512 512 7,050 6,880 -170 (-2.4%)
share_escrow 401,780 401,780 704 704 512 512 6,098 5,895 -203 (-3.3%)

Contract: nft

Function Gates DA Gas L2 Gas Proving Time (ms)
Status Base PR Diff Base PR Diff Base PR Diff Base PR Diff
burn_private 453,593 453,593 416 416 133,273 133,273 6,452 6,289 -163 (-2.5%)
burn_public 340,754 340,754 448 448 145,897 145,897 5,545 5,351 -194 (-3.5%)
mint_to_private 451,883 451,883 960 960 121,679 121,679 6,494 6,275 -219 (-3.4%)
mint_to_public 340,754 340,754 448 448 148,564 148,564 5,525 5,345 -180 (-3.3%)
transfer_private_to_private 407,622 407,622 736 736 512 512 6,191 5,930 -261 (-4.2%)
transfer_private_to_public 453,669 453,669 416 416 128,071 128,071 6,467 6,342 -125 (-1.9%)
transfer_public_to_private 448,522 448,522 960 960 121,763 121,763 6,490 6,279 -211 (-3.3%)
transfer_public_to_public 340,754 340,754 384 384 102,797 102,797 5,549 5,359 -190 (-3.4%)

Contract: token

Function Gates DA Gas L2 Gas Proving Time (ms)
Status Base PR Diff Base PR Diff Base PR Diff Base PR Diff
burn_private 465,634 473,363 +7,729 (+1.7%) 992 992 147,583 147,961 +378 (+0.3%) 6,631 6,415 -216 (-3.3%)
🔴 burn_public 340,754 340,754 448 448 136,810 146,494 +9,684 (+7.1%) 5,611 5,320 -291 (-5.2%)
initialize_transfer_commitment 420,275 420,275 704 704 512 512 6,250 6,026 -224 (-3.6%)
mint_to_private 451,900 455,955 +4,055 (+0.9%) 960 960 116,540 116,918 +378 (+0.3%) 6,564 6,336 -228 (-3.5%)
🔴 mint_to_public 340,754 340,754 448 448 145,006 154,690 +9,684 (+6.7%) 5,595 5,440 -155 (-2.8%)
transfer_private_to_commitment 432,438 440,168 +7,730 (+1.8%) 864 864 512 512 6,351 6,159 -192 (-3.0%)
transfer_private_to_private 430,103 437,832 +7,729 (+1.8%) 1,312 1,312 512 512 6,289 6,147 -142 (-2.3%)
transfer_private_to_public 465,710 473,439 +7,729 (+1.7%) 992 992 150,457 150,754 +297 (+0.2%) 6,576 6,405 -171 (-2.6%)
transfer_private_to_public_with_commitment 494,396 502,125 +7,729 (+1.6%) 1,568 1,568 181,257 181,554 +297 (+0.2%) 6,818 6,571 -247 (-3.6%)
🔴 transfer_public_to_commitment 340,754 340,754 544 544 133,070 142,673 +9,603 (+7.2%) 5,547 5,385 -162 (-2.9%)
transfer_public_to_private 448,554 456,275 +7,721 (+1.7%) 960 960 119,738 120,035 +297 (+0.2%) 6,491 6,302 -189 (-2.9%)
🔴 transfer_public_to_public 340,754 340,754 448 448 139,501 149,107 +9,606 (+6.9%) 5,596 5,354 -242 (-4.3%)

Contract: tokenized_vault

Function Gates DA Gas L2 Gas Proving Time (ms)
Status Base PR Diff Base PR Diff Base PR Diff Base PR Diff
deposit_private_to_private 696,598 704,327 +7,729 (+1.1%) 1,280 1,280 296,596 297,568 +972 (+0.3%) 8,637 8,568 -69 (-0.8%)
deposit_private_to_private_exact 726,183 733,912 +7,729 (+1.1%) 1,856 1,856 328,065 329,037 +972 (+0.3%) 8,889 8,720 -169 (-1.9%)
deposit_private_to_public 696,335 704,064 +7,729 (+1.1%) 768 768 316,017 316,989 +972 (+0.3%) 8,682 8,562 -120 (-1.4%)
🔴 deposit_public_to_private 448,564 448,564 1,344 1,344 363,653 375,239 +11,586 (+3.2%) 6,532 6,407 -125 (-1.9%)
🔴 deposit_public_to_private_exact 477,308 477,308 1,920 1,920 395,020 406,870 +11,850 (+3.0%) 6,727 6,584 -143 (-2.1%)
🔴 deposit_public_to_public 340,754 340,754 832 832 381,277 393,127 +11,850 (+3.1%) 5,569 5,452 -117 (-2.1%)
issue_private_to_private_exact 882,551 890,280 +7,729 (+0.9%) 1,856 1,856 328,305 329,013 +708 (+0.2%) 10,189 10,001 -188 (-1.8%)
issue_private_to_public_exact 882,311 890,040 +7,729 (+0.9%) 1,344 1,344 347,753 348,725 +972 (+0.3%) 10,394 10,147 -247 (-2.4%)
🔴 issue_public_to_private 448,555 448,555 1,344 1,344 364,574 376,424 +11,850 (+3.3%) 6,545 6,336 -209 (-3.2%)
🔴 issue_public_to_public 340,754 340,754 832 832 381,646 393,496 +11,850 (+3.1%) 5,567 5,457 -110 (-2.0%)
redeem_private_to_private_exact 760,399 768,120 +7,721 (+1.0%) 1,824 1,824 297,574 298,282 +708 (+0.2%) 9,082 8,915 -167 (-1.8%)
🔴 redeem_private_to_public 465,710 465,710 736 736 286,562 296,843 +10,281 (+3.6%) 6,565 6,333 -232 (-3.5%)
redeem_public_to_private_exact 742,839 750,560 +7,721 (+1.0%) 1,856 1,856 305,659 306,631 +972 (+0.3%) 8,986 8,733 -253 (-2.8%)
🔴 redeem_public_to_public 340,754 340,754 768 768 293,279 303,560 +10,281 (+3.5%) 5,544 5,354 -190 (-3.4%)
withdraw_private_to_private 581,025 588,746 +7,721 (+1.3%) 1,248 1,248 265,460 266,432 +972 (+0.4%) 7,507 7,373 -134 (-1.8%)
withdraw_private_to_private_exact 600,752 608,473 +7,721 (+1.3%) 1,824 1,824 297,172 298,144 +972 (+0.3%) 7,665 7,433 -232 (-3.0%)
🔴 withdraw_private_to_public_exact 485,444 485,444 1,312 1,312 318,058 328,339 +10,281 (+3.2%) 6,737 6,465 -272 (-4.0%)
withdraw_public_to_private 563,613 571,334 +7,721 (+1.4%) 1,280 1,280 273,437 274,409 +972 (+0.4%) 7,440 7,289 -151 (-2.0%)
🔴 withdraw_public_to_public 340,754 340,754 768 768 293,198 303,479 +10,281 (+3.5%) 5,549 5,352 -197 (-3.6%)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 9, 2026

Benchmark Comparison

CPU Cores RAM Arch
AMD EPYC 9V74 80-Core Processor 16 63 GiB x64

Contract: escrow

Function Gates DA Gas L2 Gas Proving Time (ms)
Status Base PR Diff Base PR Diff Base PR Diff Base PR Diff
(partial) withdraw 538,526 546,181 +7,655 (+1.4%) 1,312 1,312 512 512 7,388 7,464 +76 (+1.0%)
withdraw 538,526 546,181 +7,655 (+1.4%) 736 736 512 512 7,423 7,474 +51 (+0.7%)
withdraw_nft 516,039 516,039 736 736 512 512 7,311 7,288 -23 (-0.3%)

Contract: logic

Function Gates DA Gas L2 Gas Proving Time (ms)
Status Base PR Diff Base PR Diff Base PR Diff Base PR Diff
get_escrow 519,275 519,275 128 128 512 512 7,272 7,334 +62 (+0.9%)
secret_key_to_public_keys 514,355 514,355 128 128 512 512 7,265 7,266 +1 (+0.0%)
share_escrow 401,780 401,780 704 704 512 512 6,277 6,261 -16 (-0.3%)

Contract: nft

Function Gates DA Gas L2 Gas Proving Time (ms)
Status Base PR Diff Base PR Diff Base PR Diff Base PR Diff
burn_private 453,593 453,593 416 416 133,273 132,970 -303 (-0.2%) 6,691 6,683 -8 (-0.1%)
burn_public 340,754 340,754 448 448 145,897 145,594 -303 (-0.2%) 5,762 5,738 -24 (-0.4%)
mint_to_private 451,883 451,883 960 960 121,679 121,376 -303 (-0.2%) 6,756 6,780 +24 (+0.4%)
mint_to_public 340,754 340,754 448 448 148,564 148,261 -303 (-0.2%) 5,731 5,760 +29 (+0.5%)
transfer_private_to_private 407,622 407,622 736 736 512 512 6,347 6,316 -31 (-0.5%)
transfer_private_to_public 453,669 453,669 416 416 128,071 127,768 -303 (-0.2%) 6,696 6,686 -10 (-0.1%)
transfer_public_to_private 448,522 448,522 960 960 121,763 121,460 -303 (-0.2%) 6,684 6,679 -5 (-0.1%)
transfer_public_to_public 340,754 340,754 384 384 102,797 102,494 -303 (-0.3%) 5,735 5,706 -29 (-0.5%)

Contract: token

Function Gates DA Gas L2 Gas Proving Time (ms)
Status Base PR Diff Base PR Diff Base PR Diff Base PR Diff
burn_private 465,634 473,289 +7,655 (+1.6%) 992 992 146,569 146,590 +21 (+0.0%) 6,819 6,907 +88 (+1.3%)
🔴 burn_public 340,754 340,754 448 448 135,796 145,105 +9,309 (+6.9%) 5,743 5,718 -25 (-0.4%)
initialize_transfer_commitment 420,275 420,275 704 704 512 512 6,399 6,401 +2 (+0.0%)
mint_to_private 451,900 455,881 +3,981 (+0.9%) 960 960 115,607 115,628 +21 (+0.0%) 6,730 6,753 +23 (+0.3%)
🔴 mint_to_public 340,754 340,754 448 448 144,076 153,379 +9,303 (+6.5%) 5,749 5,727 -22 (-0.4%)
transfer_private_to_commitment 432,438 440,093 +7,655 (+1.8%) 864 864 512 512 6,514 6,509 -5 (-0.1%)
transfer_private_to_private 430,103 437,758 +7,655 (+1.8%) 1,312 1,312 512 512 6,487 6,545 +58 (+0.9%)
transfer_private_to_public 465,710 473,365 +7,655 (+1.6%) 992 992 149,488 149,428 -60 (-0.0%) 6,789 6,878 +89 (+1.3%)
transfer_private_to_public_with_commitment 494,396 502,051 +7,655 (+1.5%) 1,568 1,568 180,288 180,228 -60 (-0.0%) 6,991 7,038 +47 (+0.7%)
🔴 transfer_public_to_commitment 340,754 340,754 544 544 132,107 141,332 +9,225 (+7.0%) 5,695 5,791 +96 (+1.7%)
transfer_public_to_private 448,554 456,201 +7,647 (+1.7%) 960 960 118,769 118,709 -60 (-0.1%) 6,660 6,711 +51 (+0.8%)
🔴 transfer_public_to_public 340,754 340,754 448 448 138,499 147,727 +9,228 (+6.7%) 5,738 5,727 -11 (-0.2%)

Contract: vault

Function Gates DA Gas L2 Gas Proving Time (ms)
Status Base PR Diff Base PR Diff Base PR Diff Base PR Diff
deposit_private_to_private 861,133 872,769 +11,636 (+1.4%) 1,280 1,280 351,978 351,546 -432 (-0.1%) 10,346 10,408 +62 (+0.6%)
deposit_private_to_private_exact 997,057 1,008,693 +11,636 (+1.2%) 1,856 1,856 392,012 391,580 -432 (-0.1%) 11,492 11,619 +127 (+1.1%)
deposit_private_to_public 696,335 703,990 +7,655 (+1.1%) 768 768 380,850 389,700 +8,850 (+2.3%) 8,794 8,843 +49 (+0.6%)
🔴 deposit_public_to_private 566,895 617,174 +50,279 (+8.9%) 1,344 1,344 406,927 415,681 +8,754 (+2.2%) 7,700 8,197 +497 (+6.5%)
deposit_public_to_private_exact 742,441 746,422 +3,981 (+0.5%) 1,920 1,920 447,123 455,877 +8,754 (+2.0%) 9,286 9,265 -21 (-0.2%)
🔴 deposit_public_to_public 340,754 340,754 832 832 434,083 452,119 +18,036 (+4.2%) 5,702 5,715 +13 (+0.2%)
issue_private_to_private_exact 997,057 1,008,693 +11,636 (+1.2%) 1,856 1,856 392,288 391,856 -432 (-0.1%) 11,553 11,583 +30 (+0.3%)
🔴 issue_private_to_public_exact 835,489 886,222 +50,733 (+6.1%) 1,344 1,344 421,451 430,301 +8,850 (+2.1%) 10,082 10,491 +409 (+4.1%)
🔴 issue_public_to_private 566,895 617,174 +50,279 (+8.9%) 1,344 1,344 407,881 416,635 +8,754 (+2.1%) 7,723 8,212 +489 (+6.3%)
🔴 issue_public_to_public 340,754 340,754 832 832 434,452 452,488 +18,036 (+4.2%) 5,718 5,735 +17 (+0.3%)
redeem_private_to_private_exact 993,708 1,009,010 +15,302 (+1.5%) 1,856 1,856 392,519 392,087 -432 (-0.1%) 11,550 11,598 +48 (+0.4%)
redeem_private_to_public 696,258 703,913 +7,655 (+1.1%) 768 768 372,609 381,465 +8,856 (+2.4%) 8,860 8,965 +105 (+1.2%)
🔴 redeem_public_to_private_exact 692,872 746,817 +53,945 (+7.8%) 1,920 1,920 444,051 452,547 +8,496 (+1.9%) 8,762 9,265 +503 (+5.7%)
🔴 redeem_public_to_public 340,754 340,754 832 832 422,527 440,311 +17,784 (+4.2%) 5,695 5,718 +23 (+0.4%)
withdraw_private_to_private 857,784 873,086 +15,302 (+1.8%) 1,280 1,280 351,804 351,372 -432 (-0.1%) 10,280 10,421 +141 (+1.4%)
withdraw_private_to_private_exact 993,708 1,009,010 +15,302 (+1.5%) 1,856 1,856 392,081 391,649 -432 (-0.1%) 11,470 11,586 +116 (+1.0%)
🔴 withdraw_private_to_public_exact 835,411 886,144 +50,733 (+6.1%) 1,344 1,344 412,934 421,790 +8,856 (+2.1%) 10,102 10,459 +357 (+3.5%)
withdraw_public_to_private 563,614 571,261 +7,647 (+1.4%) 1,344 1,344 402,964 411,460 +8,496 (+2.1%) 7,694 7,737 +43 (+0.6%)
🔴 withdraw_public_to_public 340,754 340,754 832 832 422,446 440,230 +17,784 (+4.2%) 5,751 5,720 -31 (-0.5%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant