UlyssesSP: TiledMLP doc - recomputes forward twice #7664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it very clear that `TiledMLP`'s memory saving has a cost of recomputing forward.
tohtana
approved these changes
Nov 3, 2025
Collaborator
Author
|
Thank you, Masahiro |
|
I just noticed that there's a typo in this commit: |
Collaborator
Author
|
that's not a typo, it does occur trice.
in a normal non-tiled computation module only 1+2 occur. This is the price to save memory. So 25% more computation. |
aeeeeeep
pushed a commit
to aeeeeeep/DeepSpeed
that referenced
this pull request
Nov 13, 2025
Make it very clear that `TiledMLP`'s memory saving has a cost of recomputing forward. Signed-off-by: aeeeeeep <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it very clear that
TiledMLP's memory saving has a cost of recomputing forward.