[ROCm] Relax tolerances for FP8 unit test for fp16 and bf16 cases #7655
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if is_rocm_pytorch() and model_dtype == torch.float16: | ||
| rtol, atol = 3e-07, 3e-05 | ||
| if is_rocm_pytorch() and base_datatype in ["fp16", "bf16"]: | ||
| rtol, atol = 1e-07, 1e-04 |
Contributor
There was a problem hiding this comment.
@rraminen Suggest figuring out if this is HW-specific e.g. MI200/MI300?
Contributor
Author
There was a problem hiding this comment.
For ROCm, fp8 features are only supported on MI300. This workaround is needed for MI300 onwards.
There was a problem hiding this comment.
also bf16 disabled for rocm now, PR for enabling it still waiting review -> https://github.com/deepspeedai/DeepSpeed/pull/7448/files#diff-56a6081d5f623bd0c17de268c74239976682acd6386a8b83639181aa3f5a39c4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relaxing the tolerance values to enable the below two unit testa, with FP16 and BF16 data types on ROCm