fix: Document field precedence in to_dict()#9227
Merged
julian-risch merged 3 commits intodeepset-ai:mainfrom Apr 14, 2025
Merged
fix: Document field precedence in to_dict()#9227julian-risch merged 3 commits intodeepset-ai:mainfrom
julian-risch merged 3 commits intodeepset-ai:mainfrom
Conversation
Collaborator
Pull Request Test Coverage Report for Build 14431005944Details
💛 - Coveralls |
julian-risch
approved these changes
Apr 14, 2025
Member
julian-risch
left a comment
julian-risch
left a comment
There was a problem hiding this comment.
Looks good to me! 👍 Thank you @mdrazak2001 !
sjrl
pushed a commit
that referenced
this pull request
Apr 14, 2025
* fix: Document field precedence in to_dict() * add test * add release note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Document.to_dict(flatten=True)overrides first-level fields by meta fields. #9180Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.