feat: increase Mermaid timeout and make it configurable#8973
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 13674033932Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
timeoutparameter and increase the default #8967Proposed Changes:
timeoutparameter inPipeline.drawandPipeline.show, so that users can control this behavior.How did you test it?
CI; new unit test.
I also triggered e2e tests that were failing due to the timeout. -> https://github.com/deepset-ai/haystack/actions/runs/13673782419/job/38229648241?pr=8973
Notes for the reviewer
I think that waiting more than 10 seconds to get a Pipeline rendering is not nice.
I have the feeling that this might be related to the fact that we are now sending compressed data to the server (introduced in #8767) and decompression can also take time on the server. However, there have also been several recent changes in mermaid.ink that may have an impact on rendering times.
In any case, we should monitor what happens in the future.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.