Multiple messenger interface support #332
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pseusys
changed the title
RLKRo
requested changes
Mar 6, 2024
| - value: List[Callable] - The list of called handlers for each stage. Defaults to an empty `dict`. | ||
| :param messenger_interface: An `AbsMessagingInterface` instance for this pipeline. | ||
| :param messenger_interfaces: An `AbsMessagingInterface` instance for this pipeline. |
There was a problem hiding this comment.
Should also add tests for launching pipeline with multiple http interfaces and running them at the same time on different ports.
|
Could you please remind me our final decision: do we pass interfaces as dict or as array only (with default or user-specified names)? |
|
The latter. |
RLKRo
reviewed
Apr 16, 2024
|
|
||
|
|
||
| # %% | ||
| telegram_interface = PollingTelegramInterface(token=os.environ["TG_BOT_TOKEN"]) |
There was a problem hiding this comment.
This tutorial is currently broken due to calling infinity_polling in this interface.
#328 also uses self.application.run_polling to start the bot, so I'm assuming it would also cause issues.
See the tip:
https://docs.python-telegram-bot.org/en/v21.1.1/telegram.ext.application.html#telegram.ext.Application.run_polling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Multiple user interface support added.
Checklist
To Consider
.ignorefiles, scripts (such aslint), distribution manifest (if files are added/deleted)