fix(argo_objects.py): prevent recursion explosion in get_sub_nodes traversal #919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aversal The loop in get_sub_nodes caused exponential growth of current_generation, when children lists contained duplicate node IDs, leading to: 1. Iter 1: 1 node → 100 children 2. Iter 2: 100 nodes → 100 identical children (each repeated) 3. Subsequent iterations grew with exponentially increasing duplicate entries Fixed by: - Adding deduplication via list(set(next_generation))
zjgemi
approved these changes
Jun 4, 2025
Collaborator
|
That's right. Thanks for your suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loop in get_sub_nodes caused exponential growth of current_generation, when children lists contained duplicate node IDs, leading to:
Fixed by: