-
Notifications
You must be signed in to change notification settings - Fork 7
feat: implement dft damping for ase calc #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements DFT-D3 dispersion correction support for ASE-based calculations by adding customizable damping options. The implementation allows users to apply different DFT-D3 damping schemes or disable dispersion corrections entirely.
- Added
dampingparameter toDirectPredictTaskclass andrun_ase_dptestmethod with support for "d3bj", "d3zero", or None values - Integrated DFT-D3 corrections using
SumCalculatorto combine base calculator with DFTD3 when damping is specified - Updated type annotations and imports to support the new functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lambench/tasks/direct/direct_tasks.py | Added damping parameter to DirectPredictTask class with type hints and initialization |
| lambench/models/ase_models.py | Updated run_ase_dptest method to accept damping parameter and integrate DFTD3 calculator |
for more information, see https://pre-commit.ci
Co-authored-by: Copilot <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
=======================================
Coverage 65.88% 65.89%
=======================================
Files 35 35
Lines 1583 1589 +6
Branches 188 189 +1
=======================================
+ Hits 1043 1047 +4
- Misses 498 500 +2
Partials 42 42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anyangml
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request adds support for applying DFT-D3 dispersion corrections with customizable damping options to the ASE-based evaluation workflow. The main changes introduce a
dampingparameter to relevant methods and classes, allowing users to specify the type of damping used in DFT-D3 corrections, and update the calculator setup accordingly.DFT-D3 Dispersion Correction Support:
dampingparameter (of typeLiteral["d3bj", "d3zero"] | None) toDirectPredictTaskand therun_ase_dptestmethod, enabling the selection of DFT-D3 damping schemes or disabling them. (lambench/tasks/direct/direct_tasks.py,lambench/models/ase_models.py) [1] [2] [3]dampingparameter from the task to the DFT-D3 setup. (lambench/models/ase_models.py)run_ase_dptestto use aSumCalculatorthat combines the original calculator with a DFTD3 correction ifdampingis specified. (lambench/models/ase_models.py)SumCalculatorandDFTD3to support the new functionality. (lambench/models/ase_models.py)Literalfor the newdampingparameter. (lambench/models/ase_models.py,lambench/tasks/direct/direct_tasks.py) [1] [2]