-
Notifications
You must be signed in to change notification settings - Fork 729
Upgrade dependency version #3049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
frankfliu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please
| commons_logging_version=1.3.1 | ||
| gson_version=2.10.1 | ||
| jna_version=5.13.0 | ||
| slf4j_version=1.7.36 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep slf4j 1.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
gradle.properties
Outdated
| ffmpeg_version=6.0-1.5.9 | ||
| awssdk_version=2.25.17 | ||
| hadoop_version=3.4.0 | ||
| javacpp_version=1.5.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep java cpp 1.5.9, we can upgrade in next release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| slf4j_version=2.0.12 | ||
| log4j_slf4j_version=2.23.1 | ||
| awssdk_version=2.25.13 | ||
| hadoop_version=3.3.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let upgrade hadoop in next release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
gradle.properties
Outdated
| javacv_version=1.5.9 | ||
| ffmpeg_version=6.0-1.5.9 | ||
| javacv_version=1.5.10 | ||
| ffmpeg_version=6.1.1-1.5.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are using javacpp 1.5.10 as well, no upgrade for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3049 +/- ##
============================================
- Coverage 72.31% 72.26% -0.05%
Complexity 7296 7296
============================================
Files 722 722
Lines 32551 32551
Branches 3402 3402
============================================
- Hits 23538 23522 -16
- Misses 7389 7409 +20
+ Partials 1624 1620 -4 ☔ View full report in Codecov by Sentry. |
Description
Brief description of what this PR is about