Skip to content

Conversation

@Avenger-285714
Copy link
Member

Fix follow errors:

drivers/net/can/phytium/phytium_can_platform.c: In function ‘phytium_can_plat_probe’: drivers/net/can/phytium/phytium_can_platform.c:113:41: error: ‘phytium_can_of_ids’ undeclared (first use in this function); did you mean ‘phytium_can_acpi_ids’?
113 | of_id = of_match_device(phytium_can_of_ids, &pdev->dev);
| ^~~~~~~~~~~~~~~~~~
| phytium_can_acpi_ids
drivers/net/can/phytium/phytium_can_platform.c:113:41: note: each undeclared identifier is reported only once for each function it appears in

Fix follow errors:

drivers/net/can/phytium/phytium_can_platform.c: In function ‘phytium_can_plat_probe’:
drivers/net/can/phytium/phytium_can_platform.c:113:41: error: ‘phytium_can_of_ids’ undeclared (first use in this function); did you mean ‘phytium_can_acpi_ids’?
  113 |                 of_id = of_match_device(phytium_can_of_ids, &pdev->dev);
      |                                         ^~~~~~~~~~~~~~~~~~
      |                                         phytium_can_acpi_ids
drivers/net/can/phytium/phytium_can_platform.c:113:41: note: each undeclared identifier is reported only once for each function it appears in

Signed-off-by: WangYuli <[email protected]>
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • phytium_can_plat_probe函数中,of_id变量被声明但未在后续代码中使用,应检查是否遗漏了相关的逻辑。
  • devtype变量被重新声明,可能会导致混淆,建议使用不同的变量名以避免潜在的命名冲突。
  • #ifdef CONFIG_OF#endif之间的代码块中,of_id变量被检查是否为NULL,但在#else分支中没有看到相应的处理逻辑。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from avenger-285714. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants