add annotations + podAnnotations #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
nabokihms
requested changes
Aug 3, 2024
Contributor
nabokihms
left a comment
nabokihms
left a comment
There was a problem hiding this comment.
Thanks, @0xbilko. This is a great improvement. Can you bump the chart version? (it is required to automatically release a new version on artifacthub)
Contributor
Author
|
@nabokihms, done |
Contributor
|
Doc is not up to date. Could you execute the make docs command as well? |
Contributor
Author
|
@nabokihms, done |
Signed-off-by: beliys <[email protected]> Signed-off-by: bko <[email protected]>
Signed-off-by: Oleksander B <[email protected]> Signed-off-by: bko <[email protected]>
Signed-off-by: bko <[email protected]>
Signed-off-by: bko <[email protected]>
nabokihms
reviewed
Aug 20, 2024
Signed-off-by: Maksim Nabokikh <[email protected]>
Contributor
|
@0xbilko thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #170
I also prefer to scrape via the
prometheus.io/scrape: 'true'annotation