Fixed the function fetchWithRetries from streaming-client.js#24
Open
scgreenhalgh wants to merge 2 commits intode-id:mainfrom
Open
Fixed the function fetchWithRetries from streaming-client.js#24scgreenhalgh wants to merge 2 commits intode-id:mainfrom
scgreenhalgh wants to merge 2 commits intode-id:mainfrom
Conversation
…so a response from the API which is not in the status code 2XX range. Previously it would not retry if it returned any status code and only caught connection errors/network errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed the function fetchWithRetries to correctly retry if there is also a response from the API that is not in the status code 2XX range. Previously, it would not retry if it returned any status code and only caught connection errors/network errors.