Open
Conversation
Collaborator
|
Hi @lwehrhan, thank you for your PR and its looking great overall! A few things:
Once we've got the data file uploaded, i think we can make a few changes to the calc script for consistency with similar benchmarks, but i think the changes will be minor. Just a note, make sure you to fetch any changes i've made before working locally, otherwise your next push may overwrite my changes. thanks! |
joehart2001
reviewed
Mar 18, 2026
| # Add D3 calculator for this test | ||
| calc = model.add_d3_calculator(calc) | ||
|
|
||
| data_path = Path(__file__).parent / "data" / "folmsbee_dataset.json" |
Collaborator
There was a problem hiding this comment.
Suggested change
| data_path = Path(__file__).parent / "data" / "folmsbee_dataset.json" | |
| data_path = ( | |
| download_s3_data( | |
| filename="Folmsbee.zip", | |
| key="inputs/conformers/Folmsbee/Folmsbee.zip", | |
| ) | |
| / "Folmsbee" | |
| ) |
joehart2001
reviewed
Mar 18, 2026
| import pytest | ||
| from tqdm import tqdm | ||
|
|
||
| from ml_peg.models.get_models import load_models |
Collaborator
There was a problem hiding this comment.
Suggested change
| from ml_peg.models.get_models import load_models | |
| from ml_peg.calcs.utils.utils import download_s3_data | |
| from ml_peg.models.get_models import load_models |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist for PR author
PR author must check the checkboxes below when creating the PR.
Summary
The Folmsbee dataset of low-energy conformers of drug-like molecules. The differences in energy are smaller compared to the Wiggle500 dataset and it features a greater number of molecules. The highest available level of theory for energy evaluations to be used as ground-truth is DLPNO-CCSD(T). This is a test for moving the benchmarks of mlip-audit into this repository. I have included an analysis script for this benchmark, however would like to kindly ask for assistance with building and harmonizing the Dash layout.
Linked issue
Resolves #427
Progress
Testing
New decorators/callbacks