Skip to content

Conversation

@stasadev
Copy link
Member

The Issue

I noticed that .ddev/docker-compose.redis_extra.yaml is not removed on add-on uninstall.

How This PR Solves The Issue

Removes it

Manual Testing Instructions

ddev dotenv set .ddev/.env.redis --redis-optimized=true
ddev add-on get https://github.com//ddev/ddev-redis/tarball/20250722_stasadev_cleanup
ddev add-on remove redis
rm -f .ddev/.env.redis
git status # should be clean

Automated Testing Overview

Release/Deployment Notes

@stasadev stasadev merged commit 46ee74a into main Jul 22, 2025
20 checks passed
@stasadev stasadev deleted the 20250722_stasadev_cleanup branch July 22, 2025 09:22
@rfay
Copy link
Member

rfay commented Jul 22, 2025

Normally .ddev/docker-compose.redis_extra.yaml is not created by the add-on, true? So doesn't have #ddev-generated, so not truly our responsibility to remove it?

@stasadev
Copy link
Member Author

It's created automatically in the optimized config:

extra_docker_file="${DDEV_APPROOT}/.ddev/docker-compose.redis_extra.yaml"

if [ ! -f "${extra_docker_file}" ] || grep -q '#ddev-generated' "${extra_docker_file}"; then
cat >"${extra_docker_file}" <<EOF
#ddev-generated
services:
redis:
deploy:
resources:
limits:
cpus: "2.5"
memory: "768M"
reservations:
cpus: "1.5"
memory: "512M"
EOF
fi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants