Skip to content

Conversation

@tyler36
Copy link
Contributor

@tyler36 tyler36 commented Apr 30, 2025

The Issue

How This PR Solves The Issue

This PR attempts to remove the redis command if it is ownded by DDEV.

Manual Testing Instructions

  1. Create new project
ddev config
  1. Add ddev-redis-7
ddev addon get ddev/ddev-redis-7
  1. Restart DDEV
ddev restart
  1. Migrate to ddev-redis
ddev dotenv set .ddev/.env.redis --redis-optimized=true
ddev add-on get https://github.com/ddev/ddev-redis/tarball/refs/pull/47/head
ddev restart
  1. Run DDEV command and confirm Command 'redis-cli' cannot have alias does NOT appear.
$ ddev -v   
ddev version v1.24.4

Automated Testing Overview

Release/Deployment Notes

@stasadev stasadev changed the title Remove old redis command from ddev-redis-7 fix: remove old redis command from ddev-redis-7, fixes #46 Apr 30, 2025
Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I have to admit, I didn't test the actual migration from ddev-redis-7 to ddev-redis.

This PR solves the problem with alias.

@stasadev stasadev merged commit 5eb87b4 into ddev:main Apr 30, 2025
2 checks passed
@tyler36 tyler36 deleted the 20250430-Remove-old-`redis`-command-from-`ddev-redis-7` branch April 30, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants