What does the optimized config do?

[hanoii]

It's unclear to me why would I chose one over the other. I haven't looked in depth into the configs but a brief explanation of what it does might be good to have on the README

[stasadev]

It’s basically what ddev/ddev-redis-7 used, all config files from https://github.com/ddev/ddev-redis/tree/main/redis, whereas a usual setup has only redis.conf.

I haven’t archived ddev/ddev-redis-7 yet. The README.md there has some explanation but it’s outdated and not fully accurate.

Will return here once this issue is resolved:

• Archive add-on because it's functionality is integrated into ddev/ddev-redis ddev-redis-7#36

[hanoii]

Thanks! I am still unclear what was the reason or why would want to enable this, and if we do, wouldn't we want to modify this configs? I understand the how I just wonder why something like this should be in an add-on.

EDIT: I am sure there's a reason, but not couldn't think of one.

[stasadev]

what was the reason or why would want to enable this

If you want to dig deeper, see the comments left by @seebeen here:

• Implemented redis persistence  #18
• Figure out how to specify redis version #1

It was a long discussion, and at the end we decided to create another add-on (because there was no flexibility to enable/disable these configs). And now I have added all the logic to one add-on (easier to maintain).

[gitressa]

Thanks for maintaining DDEV, including this great add-on @stasadev :)

I am updating the Redis README (Document the most basic set up for DDEV and server) and the maintainer @Berdir recommends using the standard example, not DDEV's tweaked version ...:

DDEV includes a new settings.ddev.redis.php file in settings.php ("IS_DDEV_PROJECT") which should not be used, since it's DDEV specific.

You'll need most settings also for a non-DDEV setup on your server, so instead copy settings.redis.example.php to settings.redis.php, and include it with the below in settings.php. For local DDEV setup, just override the hostname:

# Redis settings file
if (file_exists($app_root . '/' . $site_path . '/settings.redis.php')) {
  include $app_root . '/' . $site_path . '/settings.redis.php';
}
# DDEV: Override hostname for local setup, remove on PROD server
$settings['redis.connection']['host'] = 'redis';

I can confirm that the DDEV Redis add-on works well, with just this in settings.php, and not using settings.ddev.redis.php.

[stasadev]

# DDEV: Override hostname for local setup, remove on PROD server
$settings['redis.connection']['host'] = 'redis';

@gitressa, you can wrap that in:

if (getenv('IS_DDEV_PROJECT') == 'true') {
    $settings['redis.connection']['host'] = 'redis';
}

---

And I think you want to prevent this add-on from making changes to settings.php on update:

ddev config --disable-settings-management

---

P.S.: I don't like the approach with settings.php. It reminds the early days of PHP.
When will Drupal switch to using a standard .env file instead of manual edits in that file 🤔

[gitressa]

Thanks for a fast reply, and tip about the wrapper @stasadev.

(About the tip to prevent the add-on from making changes to settings.php on update, it seemed to be too drastic, and stopped many things from working ...)

But now the question is, if the DDEV Redis add-on set up should be updated somehow ... like, should DDEV after add-on install then not use a settings.ddev.redis.php file, but instead create a copy of settings.redis.example.php as settings.redis.php and insert this in settings.php?

# Redis settings file
if (file_exists($app_root . '/' . $site_path . '/settings.redis.php')) {
  include $app_root . '/' . $site_path . '/settings.redis.php';
  if (getenv('IS_DDEV_PROJECT') == 'true') {
    $settings['redis.connection']['host'] = 'redis';
  }
}

About settings.php ... that's just how it's always been, I guess ... But you should totally feel free to create a Drupal core issue

Drupal needs new, fresh ideas from the outside!

[stasadev]

But now the question is, if the DDEV Redis add-on set up should be updated somehow ... like, should DDEV after add-on install then not use a settings.ddev.redis.php file, but instead create a copy of settings.redis.example.php as settings.redis.php and insert this in settings.php?

Everything is done here: https://github.com/ddev/ddev-redis/blob/main/redis/scripts/setup-drupal-settings.sh

If using settings.redis.php is simpler, you can prepare a PR for that. (I have no idea how to install modules in Drupal.)
The script can have several conditions and modify the settings.php in appropriate way.

About settings.php ... that's just how it's always been, I guess ... But you should totally feel free to create a Drupal core issue

FWIW, the support for dotenv is already there https://www.drupal.org/project/dotenv, it's just not the default.

And I'm sure Drupal already has a lot of suggestions, similar to this https://www.drupal.org/project/drupal/issues/3445816

[Berdir]

Note that this issue is/was about configuration for the redis database, not the redis drupal module, that's something else entirely.

The provided ddev.settings.redis.php is essentially based on the example, just an older version. The update script could check if if the module is installed and copy the example from there, which would have the advantage that it also has newer recommendations in there but it would then somehow need to set the hostname specifically for ddev still. It doesn't need to install the drupal module, at most check if it exists locally in the default place.

My point in the drupal.org issue is that you likely want to a redis settings.php for your project that you own and use across all environments, I'm not sure if ddev-redis is really responsible for setting that up for you, it kind of makes sense to me that it only does it for itself, just like ddev itself also just configures the database for ddev.

[gitressa]

Thanks for clarifying @Berdir, my only aim with my comment here was to simplify the settings.php / settings.redis.php workflow for the end user. And the settings.redis.example.php file works well as it is in DDEV, the only thing that needs adjustment is the host.

[gitressa]

And by the way, thanks for the link to the script @stasadev, and Drupal issues, maybe one day we'll get env files? :)
It's very easy to install a Drupal module like Drupal Redis, just run this:

composer require drupal/redis
drush install redis

@Berdir:

The update script could check if if the module is installed and copy the example from there [...]

Thinking more about this, does it even need to copy the example file -- maybe it could just use it as it is? Something along these lines seems to work well:

// Include settings required for Redis cache.
if (file_exists($app_root . '/modules/contrib/redis/settings.redis.example.php')) {
  include $app_root . '/modules/contrib/redis/settings.redis.example.php';
  $settings['redis.connection']['host'] = 'redis';
}