shelley genesis: support fractional slot length#361
Merged
SebastienGllmt merged 2 commits intodevelopfrom Sep 21, 2024
Merged
Conversation
rooooooooob
suggested changes
Sep 20, 2024
| pub protocol_params: ShelleyGenesisProtocolParameters, | ||
| pub security_param: u64, | ||
| pub slot_length: u64, | ||
| pub slot_length: String, |
Contributor
There was a problem hiding this comment.
Shouldn't this be a Fraction like active_slots_coeff? That one is only a String to avoid f64 losing precision in raw.rs's field, but is Fraction here.
SebastienGllmt
approved these changes
Sep 20, 2024
SebastienGllmt
deleted the
shelley-genesis-support-fractional-slot-length
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when trying to parse the shelley genesis file generated by yaci-devkit I got an error because the slotLength it's
1.0instead of1. It seems like the value can be actually have decimals (e.g https://github.com/bloxbean/yaci-devkit/blob/bef2cf9252972b6935b59650b347d95d78480278/applications/cli/src/main/java/com/bloxbean/cardano/yacicli/localcluster/ClusterCommands.java#L98 ), although I'm actually not sure if there is a spec for these fields anywhere.