Merged
Conversation
Fixes #289 For script data hashing we do not pass in the witness set encodings like in the rust bindings. We might wish to expose the CBOR encodings generally, or for this API we could have something that takes in the entire witness set. This function is likely to be used more indirectly via the builders anyway.
SebastienGllmt
approved these changes
Dec 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing hashing/crypto WASM bindings
Fixes #289
Adds script data hash creation from witness sets since the encoding info is not directly available from WASM bindings. This might be something we want to change in the future but for now none of it is exposed.