Open
Conversation
cmcarthur
approved these changes
Apr 11, 2019
tap_s3_csv/csv_handler.py
Outdated
| char = chr(byte) | ||
| if char == '\n': | ||
| yield buf.encode('utf-8') | ||
| buf = "" |
Member
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
wait.... why do we need to break this down into lines at all? it seems like you could just pass the result of gunzip to the csv.DictReader
drewbanin
force-pushed
the
gzip-and-custom-delimiters
branch
from
af165e4 to
b5c13ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
delimiter(string) field to control the csv delimiterunzip(bool) field to optionally gunzip the file before reading it as a csv(work in progress)