Skip to content

Convert tox tests to central workflow#947

Merged
emmyoop merged 4 commits intomainfrom
er/use-shared-workflow
Sep 26, 2024
Merged

Convert tox tests to central workflow#947
emmyoop merged 4 commits intomainfrom
er/use-shared-workflow

Conversation

@emmyoop
Copy link
Member

@emmyoop emmyoop commented Sep 9, 2024

Follow-up to #919

Problem

dbt-utils maintaining it's own testing within the workflow. This required a high understanding of how to parse files and run the tests.

Solution

Start using a centralized workflow to ensure testing is done in a consistent way.

Moving to use https://github.com/dbt-labs/dbt-package-testing/blob/main/.github/workflows/ci.yml

Checklist

  • This code is associated with an issue which has been triaged and accepted for development.
  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the README.md (if applicable)

@emmyoop emmyoop requested a review from dbeatty10 September 9, 2024 15:26
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love simplification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants