Skip to content

Slugify handle empty strings#912

Merged
dbeatty10 merged 5 commits intomainfrom
slugify-handle-empty-strings
Jun 4, 2024
Merged

Slugify handle empty strings#912
dbeatty10 merged 5 commits intomainfrom
slugify-handle-empty-strings

Conversation

@dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Jun 4, 2024

resolves #773

Original PR: #774 by @atvaccaro

This is a:

  • documentation update
  • bug fix with no breaking changes
  • new functionality
  • a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

As of the 1.0 release, slugify now prepends an underscore in the case of leading numbers. This throws an exception if the string is empty, but we can just return falsy strings without any modification.

Another option would be using a capture group or positive lookahead.

Checklist

  • This code is associated with an Issue which has been triaged and accepted for development.
  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I followed guidelines to ensure that my changes will work on "non-core" adapters by:
    • dispatching any new macro(s) so non-core adapters can also use them (e.g. the star() source)
    • using the limit_zero() macro in place of the literal string: limit 0
    • using dbt.type_* macros instead of explicit datatypes (e.g. dbt.type_timestamp() instead of TIMESTAMP
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@dbeatty10 dbeatty10 marked this pull request as ready for review June 4, 2024 23:09
@dbeatty10 dbeatty10 merged commit cb8dd4b into main Jun 4, 2024
@dbeatty10 dbeatty10 mentioned this pull request Jun 4, 2024
17 tasks
@dbeatty10 dbeatty10 added the bug Something isn't working label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dbt_utils 1.0 fails to handle empty strings in slugify

2 participants