Typo of not_null_proportion in README.md#853
Merged
dbeatty10 merged 1 commit intodbt-labs:mainfrom Apr 18, 2024
Merged
Conversation
dbeatty10
approved these changes
Apr 18, 2024
Contributor
dbeatty10
left a comment
There was a problem hiding this comment.
Thank you @PChambino !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a:
Description & motivation
I was looking if
not_null_proportionsupported grouping and noticed this inconsistency in the README which confused me about which was the correct spelling. It is a small change, but hopefully avoids confusion for people looking at it in the future.Checklist
star()source)limit_zero()macro in place of the literal string:limit 0dbt.type_*macros instead of explicit datatypes (e.g.dbt.type_timestamp()instead ofTIMESTAMP