Update not_null_proportion data test to use cross-database type_numeric() macro#800
Merged
dbeatty10 merged 5 commits intodbt-labs:mainfrom Jul 2, 2024
Merged
Conversation
Signed-off-by: Henri Blancke <blanckehenri@gmail.com>
Signed-off-by: Henri Blancke <blanckehenri@gmail.com>
5 tasks
Contributor
Author
|
@joellabes would it be possible for you to take a look at his? Let me know if anything needs changing. Thanks! |
|
@henriblancke would you try to fix conflicts and try again. I hope someone will merge it. |
|
This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days. |
|
Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers. |
not_null_proportion data test to use cross-database type_numeric() macro
dbeatty10
approved these changes
Jul 2, 2024
Contributor
dbeatty10
left a comment
There was a problem hiding this comment.
Thanks for opening this @henriblancke !
The pre-existing tests are passing, so this looks good to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #553
This is a:
Description & motivation
Checklist
star()source)limit_zero()macro in place of the literal string:limit 0dbt.type_*macros instead of explicit datatypes (e.g.dbt.type_timestamp()instead ofTIMESTAMP