standardize yml indentation under the 'models:' line on the README#613
Merged
dbeatty10 merged 1 commit intodbt-labs:mainfrom Jun 21, 2022
Merged
Conversation
Contributor
Author
|
Question for the team: seeing as this is only an update to the README, do I need to:
Thank you! |
dbeatty10
approved these changes
Jun 21, 2022
Contributor
dbeatty10
left a comment
There was a problem hiding this comment.
Thank you for fixing this indentation, @leoebfolsom ! 🙌
No need to open an issue or update the CHANGELOG.
Thanks again for getting this buttoned up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a:
All pull requests from community contributors should target the
mainbranch (default).Description & motivation
The yml indentation in the README is inconsistent. As someone who is not a yml expert but tries to stay consistent, wants my team to be consistent, and aspires to mostly get my yml indentation right on the first go, it is confusing to see inconsistency in the README.
Checklist
star()source)limit_zero()macro in place of the literal string:limit 0dbt_utils.type_*macros instead of explicit datatypes (e.g.dbt_utils.type_timestamp()instead ofTIMESTAMP