patch union_relations macro to avoid including 'collation' in cast#1063
Closed
colin-rogers-dbt wants to merge 1 commit intomainfrom
Closed
patch union_relations macro to avoid including 'collation' in cast#1063colin-rogers-dbt wants to merge 1 commit intomainfrom
colin-rogers-dbt wants to merge 1 commit intomainfrom
Conversation
Contributor
|
Solved in dbt-labs/dbt-adapters#1510 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #
Problem
We recently updated dbt-snowflake to return the collation on a column as part of the data_type as it will soon be required when altering a column's data type (if it's a string). Most of the time this is correct, unless you want to use that datatype in a
cast.Solution
Add a macro with a snowflake specific override to scrub
collationfrom the datatype if it's present.Checklist