-
Notifications
You must be signed in to change notification settings - Fork 275
Closed as not planned
Labels
StaleMark an issue or PR as stale, to be closedMark an issue or PR as stale, to be closed
Description
Problem:
- The way exceptions are raised often the only way to distinguish them when catching is to match on the string message. Updating wording of exceptions is a frequent community-driven improvement but has high risk of changing our exception handling anywhere in the system.
- User-facing string formatting is decentralized and often would require painstaking string parsing to extract important values if downstream code wanted to render the exception differently. Here is an example of this problem with ansi characters: (Issue) (Originating Exception)
- Catching exceptions from warehouse drivers often uses the string matching strategy as well. This leaves our exception handling strategy dependent on warehouse language settings being set to English. Exceptions are not properly handled for other languages. Example for Japanese.
Goals:
- near zero risk of modifying exception messages
- catching errors works across all warehouse language settings
Possible Solution:
- leverage the event subsystem for exceptions as well
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
StaleMark an issue or PR as stale, to be closedMark an issue or PR as stale, to be closed