Skip to content

Improvement to linear regression trend#919

Merged
davidhealey merged 5 commits intodavidhealey:masterfrom
Frylen:StatsLinearRegression
Jul 18, 2025
Merged

Improvement to linear regression trend#919
davidhealey merged 5 commits intodavidhealey:masterfrom
Frylen:StatsLinearRegression

Conversation

@Frylen
Copy link
Copy Markdown
Contributor

@Frylen Frylen commented Jul 18, 2025

This is a small improvement on #918.

Changes:

  • Instead of only showing a sign in the trend value when the value is negative, it will now display a + sign on a rising trend and a ± sign on a neutral trend.
  • The title of the trend field got updated from "Trend" to "Daily Trend" to show that the trend value is "per day" for the selected timeframe.
  • Fixes the calculation, going from 0 to n-1 instead of 0 to n.

Frylen added 4 commits July 16, 2025 21:48
Update the name of the trend field to better encapsulate the trend being "daily over the n selected days", e.g. "±X kg per day on average".
Adding the optional "+" sign on a positive trend makes it easier to understand the trend direction. Same applies on a stagnating trend of 0 and the "±" sign.
@EmilJunker
Copy link
Copy Markdown
Contributor

@Frylen Please remove the German translation keys and values for "trend" and "trend-line" you added as part of #918 (or alternatively change "Trend" to something like "Täglicher Trend") because otherwise the file will be in conflict with the translation branch from Crowdin when we try to merge it.

@Frylen
Copy link
Copy Markdown
Contributor Author

Frylen commented Jul 18, 2025

Sorry, I am not sure on how to do that. I do not see any changes to locale-de.json on my end/in the linked pull request.
Do you mean show-total-portion-size in #916?

@EmilJunker
Copy link
Copy Markdown
Contributor

You are right, my mistake. Somehow my eyes deceived me. #918 indeed didn't contain any changes to the German translations, so this PR can be cleanly merged as it is.

@davidhealey davidhealey merged commit 2c1cf5a into davidhealey:master Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants