Skip to content

Add support for dask persist#77

Merged
kayibal merged 4 commits intomasterfrom
support-dask-persist
Jun 5, 2019
Merged

Add support for dask persist#77
kayibal merged 4 commits intomasterfrom
support-dask-persist

Conversation

@kayibal
Copy link
Copy Markdown

@kayibal kayibal commented Jun 4, 2019

This adds support for dask persist method.

kayibal added 2 commits June 4, 2019 12:46
This adds support for dask persist method.
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 4, 2019

Codecov Report

Merging #77 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage    89.5%   89.53%   +0.03%     
==========================================
  Files           7        7              
  Lines        1200     1204       +4     
==========================================
+ Hits         1074     1078       +4     
  Misses        126      126
Impacted Files Coverage Δ
sparsity/dask/core.py 84.98% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23f091b...2469729. Read the comment docs.

Copy link
Copy Markdown

@michcio1234 michcio1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have one remark but it's not that important.

kayibal added 2 commits June 4, 2019 14:59
# Conflicts:
#	sparsity/dask/core.py
#	sparsity/test/test_sparse_frame.py
@kayibal kayibal merged commit 6736452 into master Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants