Conversation
sparsity/sparse_frame.py
Outdated
| elif len(index) != N and data.size: | ||
| raise ValueError('Shape of passed values is {},' | ||
| 'indices imply {}' | ||
| .format(data.shape, (data.shape[0], len(index)))) |
There was a problem hiding this comment.
Firstly: should be .format(data.shape, (len(index), data.shape[1])) (similar error is below).
Secondly: if columns was also passed, then this error message will be slightly misleading (it would say that indices imply actual number of columns in data instead of number of columns passed). Same error is below.
I think this error message could be simpler and mention only one dimension. No need to solve this in smarter way.
There was a problem hiding this comment.
This is ananlogous to pandas error message.... I'll try to come up with something
|
@michcio1234 update! |
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 88.16% 88.17% +0.01%
==========================================
Files 7 7
Lines 1174 1184 +10
==========================================
+ Hits 1035 1044 +9
- Misses 139 140 +1
Continue to review full report at Codecov.
|
2 participants
No description provided.