Optimization of distributed procedures#38
Merged
Conversation
# Conflicts: # sparsity/test/test_dask_sparse_frame.py
implements distributed rename method and adds quicker routines to groupby_sum if divisions are known. Adds support for joining sp.SparseFrames onto a distributed SparseFrame.
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
- Coverage 85.55% 84.47% -1.09%
==========================================
Files 7 7
Lines 1094 1108 +14
==========================================
Hits 936 936
- Misses 158 172 +14
Continue to review full report at Codecov.
|
michcio1234
requested changes
Apr 3, 2018
michcio1234
left a comment
michcio1234
left a comment
There was a problem hiding this comment.
Cool, I have only minor remarks.
| from .shuffle import sort_index | ||
| return sort_index(self, npartitions=npartitions, divisions=None) | ||
|
|
||
| def groupby_sum(self, split_out=1, split_every=8): |
There was a problem hiding this comment.
Please add a docstring with arguments description.
| (np.array(list('0123'*25)).astype(int), False), | ||
| (np.array(list('0123'*25)).astype(float), False), | ||
| ]) | ||
| def test_groupby_sum(idx, sorted): |
There was a problem hiding this comment.
Please rename sorted parameter as currently it's misleading. Maybe known?
| sort=False, | ||
| ) | ||
| ddf2 = ddf.assign(idx=ddf.index).set_index('idx') | ||
| # ddf2.compute() |
# Conflicts: # sparsity/dask/core.py # sparsity/dask/shuffle.py # sparsity/test/test_dask_sparse_frame.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some smaller fixes and alternative procedures for the simple cases. Also adds renaming.