Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
==========================================
+ Coverage 82.31% 82.73% +0.42%
==========================================
Files 6 6
Lines 656 672 +16
==========================================
+ Hits 540 556 +16
Misses 116 116
Continue to review full report at Codecov.
|
michcio1234
reviewed
Jul 20, 2017
|
|
||
|
|
||
| @contextmanager | ||
| def mock_s3_fs(bucket, data=None): |
There was a problem hiding this comment.
@kayibal Could you please add a docstring?
Talmaj
approved these changes
Jul 20, 2017
Talmaj
left a comment
Talmaj
left a comment
There was a problem hiding this comment.
Did you try it out with large files on real S3?
Author
|
@Talmaj no I didn't but I don't see why this should be different from the tests? |
|
S3 has sometimes problems with very large files, then they suggest using multi-part upload.
… Am 20.07.2017 um 18:48 schrieb kayibal ***@***.***>:
@Talmaj no I didn't but I don't see why this should be different from the tests?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
kayibal
force-pushed
the
enhancement/npz-s3-support
branch
from
ea1595e to
f057565
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.