Skip to content

Improve typing for PolygonBox.bbox #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Improve typing for PolygonBox.bbox #291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion surya/common/polygon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ def area(self):
return self.width * self.height

@computed_field
@property
def bbox(self) -> List[float]:
x_coords = [point[0] for point in self.polygon]
y_coords = [point[1] for point in self.polygon]
Expand Down Expand Up @@ -131,4 +132,4 @@ def shift(self, x_shift: float | None = None, y_shift: float | None = None):
corner[0] += x_shift
if y_shift is not None:
for corner in self.polygon:
corner[1] += y_shift
corner[1] += y_shift
Loading