-
Notifications
You must be signed in to change notification settings - Fork 1
feat: setting up integration CICD actions #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vishpillai123
wants to merge
126
commits into
develop
Choose a base branch
from
feature/ci_cd_github_actions
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and another that will when we create a release and will gate creating a tag for production, then once a tag is pushed, then our deployment action will do CD
…ent is still funky, need to debug more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My strategy here was to combine our current git flow process (documented by @kaylawilding here in confluence) with a CICD process that ensures we are validating our pipeline prior to releases. I am planning on adding more validation and assertions in each script (where applicable) after this.
We're running all of these integration tests on a new synthetic schema that we created (I got help from @emmaeturner here): synthetic_integration. Part of the reason why we created a new schema for just integration tests is because it's easier to keep track of all artifacts (models, tables, volumes, experiments, etc.) for cleanup. We'll use our other synthetic datasets more adhoc, and this institution will be dedicated to integration tests.
NOTE: Prod deployment is still being weird and not letting me deploy as the service account. I need to debug this more with Emma, but I think this is still OK to merge for now. We likely still need to deploy manually until we get a fix.
Anyways, there's a lot in here! I summarized each process below, but let me know if you have questions.
Release Process:
git flow release start <version_number>release-integration.yml) is triggered off of the new release branch created by git flow. It then runs training then inference on dev-sst-02 and target=dev.git flow release finish -m "Releasing our super cool version 0.2.0" '0.2.0'.git push origin --tagsand we automatically deploy to staging and dev with our newest tag (deploy-main.yml). The deployment is still not working here due to a privilege issue unfortunately. It's still safe to merge, since we'll just deploy manually if it fails.Weekly Health check:
weekly-develop-integration.yml)on develop that runs training then inference on dev-sst-02 and target=dev.weekly-cleanup.yml). It cleans up tables, volumes, models, and experiments. It also has hard validation around only deleting schemas that are synthetic and in dev-sst-02 (we can change this to staging too but highly recommend we only delete synthetic to be safe).