Upgrade to DF49 #75
Merged
Upgrade to DF49 #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 tasks
xudong963
commented
Jul 25, 2025
| "| plan_type | plan |", | ||
| "+--------------+--------------------------------------------------------------------+", | ||
| "| logical_plan | Union |", | ||
| "| | Projection: coalesce(CAST(t1.year AS Utf8View), t2.year) AS year |", |
Member
Author
There was a problem hiding this comment.
After apache/datafusion#16906, the cast will be unnecessary; however, the current cast won't affect correctness.
suremarc
reviewed
Jul 30, 2025
src/rewrite/exploitation.rs
Outdated
| fn required_input_ordering(&self) -> Vec<Option<OrderingRequirements>> { | ||
| self.required_input_ordering | ||
| .as_ref() | ||
| .map(|req| vec![Some(OrderingRequirements::from(req.clone())); self.children().len()]) |
Collaborator
There was a problem hiding this comment.
Do we want to just store an OrderingRequirements in the node and update with_required_input_ordering to accept a OrderingRequirements?
Member
Author
There was a problem hiding this comment.
Sure, I applied the change
suremarc
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #74