Handle table scan filters that reference dropped columns #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xudong963
approved these changes
May 23, 2025
Closed
suremarc
added a commit
to massive-com/datafusion-materialized-views
that referenced
this pull request
May 23, 2025
…contrib#59) * use full table schema when analyzing predicates * uncomment tests * comment * fmt
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the presence of tables that can push down filters, occasionally we can have a
TableScanwith filters that reference columns not in the output set of the scan. Currently the query rewriting code does not handle this edge case when analyzing predicates. This PR changes the test to use a Parquet table with pushdown_filters enabled, and a test case to exercise this code path.