Skip to content

Conversation

@vivek-biradar
Copy link

Rule("Retail_Price_Validation", col("retail_price"), Bounds(0.0, 6.99))

Steps to reproduce the issue:

  1. Change the example DataFrame to have constant value 6.9 for retail_price column across all rows.
  2. Change the Bounds on Retail_Price_Validation Rule as below:

Rule("Retail_Price_Validation", col("retail_price"), Bounds(5.0, 6.9))

Issue : The Failed status was showing as True eventhough the InvalidCount is 0.

Fixed the logic for failed status for such non aggregate rule.

@GeekSheikh
Copy link
Contributor

That's hilarious, I wrote that exact code but I guess it got lost. Thank you so much for catching this and fixing it! Nice Work!

@GeekSheikh GeekSheikh added the bug Something isn't working label Apr 26, 2020
@GeekSheikh GeekSheikh merged commit dd47d9c into databrickslabs:master Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants