Add SparkR tab #51
Closed
Add SparkR tab #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Yep, it's case-insensitive matching: https://github.com/shivaram/spark-pr-dashboard/blob/128abefc61e6afc1c6c6b69efc75388a622a0ca8/sparkprs/models.py#L105 |
Contributor
Author
|
Cool ! A way to test this would be to see if this PR apache/spark#5436 shows up |
sparkprs/models.py
Outdated
Contributor
There was a problem hiding this comment.
For the filename regex, we might want to only match files in the top-level R folder or in the Java half of the SparkR, so how about (^r/)|src/main/r/|api/r/, which I think should cover all R-related sources?
Contributor
|
Looks like it worked! https://spark-prs.appspot.com/#r |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've kept the regex to be 'SparkR' for now as 'R' might be too verbose. BTW does it ignore case by default ? (i.e. SparkR vs. SPARKR)