Fix "migrate" to propagate --profile to "bundle plan" #4117
+107
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
Collaborator
|
Commit: 7fda971
11 interesting tests: 7 KNOWN, 2 flaky, 2 SKIP
Top 20 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Dec 9, 2025
| return nil | ||
| } | ||
|
|
||
| func getCommonArgs(cmd *cobra.Command) ([]string, string) { |
Contributor
There was a problem hiding this comment.
In the same regard, btw, do passing variables matter / is it possible here?
Contributor
Author
There was a problem hiding this comment.
Good question, I suppose we do need to carry those as well. I'll look into this in separate PR.
Collaborator
|
Commit: 685e28d
13 interesting tests: 7 KNOWN, 4 flaky, 1 SKIP, 1 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
denik
added a commit
that referenced
this pull request
Dec 18, 2025
## Changes - When "bundle deployment migrate" calls "bundle plan", propagate -var arguments. - Add a module to quote shell arguments. ## Why Follow up to #4117 ## Tests New acc test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #4088, we need to pass "-p profile" as well.