Add a language prompt to the default-minimal template #3918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplified PR description to be more concise - Added changelog entry for default-minimal template (#3885) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Added a `language_choice` property to the default-python template that prompts users to select their project's primary language: python, sql, or other. - `language_choice` (order 8): User-facing prompt with options "python", "sql", "other" - `language` (order 9): Derived property that maps user selection to template behavior - "python" → "python" (includes pyproject.toml and tests) - "sql"/"other" → "sql" (excludes pyproject.toml and tests) - Updated `__preamble.tmpl` to skip `pyproject.toml` for SQL/other projects by adding it to the existing conditional that skips tests - The derived `language` property controls which files are included/excluded in the generated project - Added concise "//" comment following the pattern used in lakeflow-pipelines template - Explains the derivation logic and what gets included/excluded The default-python template previously had a hardcoded `language` property set to "python" with no way for users to customize it for SQL or other language projects. This change allows users to: 1. Choose their project language upfront during template initialization 2. Get appropriate files for their language choice (Python projects get pyproject.toml and tests, others don't) 3. Have the README and other files reflect their language choice This makes the template more flexible and reduces manual cleanup for SQL/other language users. - Updated acceptance tests for default-python template - Manually verified all three language options: - python: includes pyproject.toml and tests - sql: excludes pyproject.toml and tests, README shows "SQL source code" - other: excludes pyproject.toml and tests, README shows "SQL source code" 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
lennartkats-db
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
approved these changes
Nov 13, 2025
Collaborator
10 failing tests:
Top 30 slowest tests (at least 2 minutes):
|
Contributor
Author
|
Tests fail, will do another pass on this |
- Only skip pyproject.toml for SQL language, not all lakeflow templates - Revert default-python to use hardcoded language property - Keep language_choice only in default-minimal template - Add back pyproject.toml for Python lakeflow-pipelines
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
deco-sdk-tagging bot
added a commit
that referenced
this pull request
Nov 19, 2025
## Release v0.278.0 ### Dependency updates * Upgrade Go SDK to 0.91.0 ([#3948](#3948)) * Bump Alpine Linux to 3.22 in the Docker image ([#3942](#3942)) ### Bundles * Update templates to use serverless environment version 4 and matching Python version ([#3897](#3897)) * Add a language prompt to the `default-minimal` template ([#3918](#3918)) * Add `default-scala` template for Scala projects with SBT build configuration and example code ([#3906](#3906))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds a language prompt (Python / SQL / other) to the
default-minimaltemplate.Why
pyproject.tomlandconftest.pyare not relevant for non-Python DABs projects like Apps projects.Tests