Add validation and translation for served_models and served_entities in serving endpoints #3880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
changed the title
shreyas-goenka
changed the title
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
requested review from
andrewnester,
anton-107,
denik and
pietern
as code owners
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Nov 5, 2025
bundle/config/mutator/resourcemutator/model_serving_endpoint_fixups.go
Outdated
Show resolved
Hide resolved
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
approved these changes
Nov 5, 2025
|
|
||
| func servedModelToServedEntity(model serving.ServedModelInput) serving.ServedEntityInput { | ||
| return serving.ServedEntityInput{ | ||
| // served_models does not support ExternalModel, so we set ExternalModel to nil |
Contributor
There was a problem hiding this comment.
// served_models
typo? should be "served entities"?
deco-sdk-tagging bot
added a commit
that referenced
this pull request
Nov 13, 2025
## Release v0.277.0 ### Bundles * Add `default-minimal` template for users who want a clean slate without sample code ([#3885](#3885)) * Add validation that served_models and served_entities are not used at the same time. Add client side translation logic. ([#3880](#3880)) * Filter out provided permissions, to select a single permissions level per principal (([#3904](#3904))).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes && Why
served_modelswas deprecated and the fields in it were moved toserved_endpoints. The GET API response for a model serving endpoint returns with bothserved_modelsandserved_entitieseven if one is set on the client side (not AIP complaint).In order to simplify the direct deployment logic, this PR translates the
served_modelsconfig toserved_entities, so that we can keep the core diff logic in direct deployment simple.Note: This is not a breaking change. TF also had the same logic with a conflicts_with annotation for
served_modelsandserved_entitiesTests
New acceptance tests. Manually confirmed that a deployment succeeds with no issues.