-
Notifications
You must be signed in to change notification settings - Fork 129
gh_report: include skipped tests in the report if they match known_failures.txt #3767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilures.txt When cloud slow tests are added to known_failures.txt then TestAccept shows up as recovered even though there are no subtests that actually recovered. This PR does not fix that but at least includes those skipped tests in the output so one can understand the reason for 'RECOVERED'
Contributor
Author
|
Example output for #3766 (comment) TestAccept/bundle/integration_whl/interactive_single_user is new addition
8 failing tests:
|
Collaborator
17 failing tests:
|
anton-107
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When CloudSlow tests are added to known_failures.txt then TestAccept shows up as "RECOVERED" even though there are no subtests that actually recovered. This PR does not fix that but at least includes those skipped tests in the output so one can understand the reason for "RECOVERED" status.