internal: Fixes for IsLocalPathInPipFlag and IsLibraryLocal #3716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnester
requested review from
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
approved these changes
Oct 3, 2025
|
|
||
| {path: "", expected: false}, | ||
| {path: "pypipackage", expected: false}, | ||
| {path: "foo-bar", expected: false}, |
Contributor
There was a problem hiding this comment.
Was this true before the regexp fix?
Contributor
Author
There was a problem hiding this comment.
It was still false anyway but for a wrong reason :) this is just for a completness of test that we don't break anything later.
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
7 failing tests:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added ^\s* for pip flag regexp so we don't match
foo-baras a flagRenamed variable to avoid shadowing
Why
Followups for #3708