Skip to content

feat: add marashal/unmarshal support for large size integer types. #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2023
Merged

feat: add marashal/unmarshal support for large size integer types. #45

merged 2 commits into from
Apr 7, 2023

Conversation

@RinChanNOWWW
Copy link
Contributor

@RinChanNOWWW RinChanNOWWW commented Apr 6, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Make i128/u128/I256/U256 can be (un)marshalled.

NOTE: I256 and U256 are from crate ethnum.

@RinChanNOWWW
Copy link
Contributor Author

RinChanNOWWW commented Apr 6, 2023

PTAL @sundy-li @PsiACE

@RinChanNOWWW RinChanNOWWW mentioned this pull request Apr 6, 2023
Merged
PsiACE
PsiACE approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PsiACE PsiACE merged commit a97d750 into databendlabs:main Apr 7, 2023
@RinChanNOWWW RinChanNOWWW deleted the more-marshal branch April 8, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@PsiACE PsiACE PsiACE approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RinChanNOWWW @PsiACE