Skip to content

Conversation

@PsiACE
Copy link
Contributor

@PsiACE PsiACE commented Mar 8, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

This is a fairly large commit, but in fact just migrating common/clickhouse-srv to opensrv-clickhouse

  • common-tarcing -> tracing
  • common-io -> opensrv-clickhouse/io (contains only marshal and unmarshal)
  • some corresponding minor modifications to ensure that the tests all pass

Since we don't need a top-level crate to manage the server for now, remove srv.

@Xuanwo
Copy link
Member

Xuanwo commented Mar 8, 2022

Will we publish them to crates.io?

@PsiACE
Copy link
Contributor Author

PsiACE commented Mar 8, 2022

Will we publish them to crates.io?

Yes. Once they are ready, we will publish them to crates.io

@PsiACE PsiACE merged commit 183b728 into databendlabs:main Mar 8, 2022
@PsiACE PsiACE deleted the clickhouse branch March 8, 2022 11:38
@drmingdrmer
Copy link
Member

What a big shot!!!

@BohuTANG
Copy link
Member

BohuTANG commented Mar 9, 2022

Love this repo ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants