chore: ensuring all imperfect blocks are compacted #18860
Merged
+104
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
When checking the compaction block limit, we now verify the number of imperfect blocks among the selected blocks.
Once reached for imperfect blocks, triggers one final segment acquisition before stopping. This “+1” segment behaviour ensures boundary blocks are not missed and avoids off-by-one omissions.
Refactors the
is_limit_reachedmethod to return an explicit state enum (CompactLimitState) with values:Continue,ReachedBlockLimit,ReachedSegmentLimit. This clarifies the intent of each stop condition and aligns the control flow with the outer loop logic.Improves readability of the compaction loop by handling the “take one more” state outside the immediate stop condition, thus making the workflow more predictable and maintainable.
This change ensures that auto-compaction covers all eligible segments/blocks without accidentally skipping near-limit items, and also tightly bounds resource usage by segments.
Fixes: #18859
Tests
Type of change
This change is