Skip to content

Conversation

@camilesing
Copy link
Contributor

@camilesing camilesing commented Oct 15, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

for issue: #18781

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - remove outdated setting

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Oct 15, 2025
@dantengsky
Copy link
Member

https://github.com/databendlabs/databend/actions/runs/18525346931/job/52870788438?pr=18841#step:4:18198

java.sql.SQLException: Query failed,no need to retry: SQL: set enable_experimental_merge_into = 1 - Query failed: QueryErrors{code=2801, message=Unknown variable: "enable_experimental_merge_into"}
	at com.databend.jdbc.DatabendConnection.wrapException(DatabendConnection.java:830)
	at com.databend.jdbc.DatabendConnection.startQueryWithFailover(DatabendConnection.java:777)
	at com.databend.jdbc.DatabendConnection.startQuery(DatabendConnection.java:863)

@hantmac Do we need to keep backward compatible for setting enable_experimental_merge_into ?

@forsaken628 forsaken628 added the ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits label Oct 16, 2025
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-18841-b59676a-1760607312

note: this image tag is only available for internal use.

@github-actions
Copy link
Contributor

Copy link
Member

@dantengsky dantengsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

@BohuTANG BohuTANG merged commit efe954b into databendlabs:main Oct 21, 2025
365 of 379 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants