Skip to content

Fix cities osm import intermitently failing test#2880

Merged
ziv17 merged 1 commit intodata-for-change:devfrom
ziv17:fix-cities-osm-import
Dec 28, 2025
Merged

Fix cities osm import intermitently failing test#2880
ziv17 merged 1 commit intodata-for-change:devfrom
ziv17:fix-cities-osm-import

Conversation

@ziv17
Copy link
Copy Markdown
Collaborator

@ziv17 ziv17 commented Dec 28, 2025

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 28, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.52%. Comparing base (b56f7d0) to head (ec68fd7).
⚠️ Report is 42 commits behind head on dev.

Files with missing lines Patch % Lines
anyway/parsers/cities.py 58.33% 5 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2880      +/-   ##
==========================================
+ Coverage   55.32%   55.52%   +0.19%     
==========================================
  Files         126      128       +2     
  Lines       10783    11329     +546     
==========================================
+ Hits         5966     6290     +324     
- Misses       4817     5039     +222     
Flag Coverage Δ
unittests 55.52% <58.33%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Changed overpass-api timeout to 100
@ziv17 ziv17 force-pushed the fix-cities-osm-import branch from 6635a39 to ec68fd7 Compare December 28, 2025 14:52
@ziv17 ziv17 requested a review from atalyaalon December 28, 2025 14:59
@ziv17 ziv17 merged commit 12d0167 into data-for-change:dev Dec 28, 2025
3 checks passed
@ziv17 ziv17 deleted the fix-cities-osm-import branch December 28, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants