Skip to content

2870 sd api fixes#2876

Merged
ziv17 merged 1 commit intodata-for-change:devfrom
ziv17:2870-sd-api-fixes
Dec 28, 2025
Merged

2870 sd api fixes#2876
ziv17 merged 1 commit intodata-for-change:devfrom
ziv17:2870-sd-api-fixes

Conversation

@ziv17
Copy link
Copy Markdown
Collaborator

@ziv17 ziv17 commented Dec 27, 2025

No description provided.

@ziv17 ziv17 force-pushed the 2870-sd-api-fixes branch from 753d074 to 3ce3b2a Compare December 27, 2025 08:16
…y and Safety-Data.

Adding safety-data admin user and role, and hot_spots_tab_grant
Adding safety-data user management endpoints
In alembic version files, use raw sql instead of ORM to avoid failure when all revisions are run from scratch to build the database for tests. ORM uses current table structure from models.py that is not consistent with the tables that were when that alembic version file was written.
@ziv17 ziv17 force-pushed the 2870-sd-api-fixes branch from 3ce3b2a to 28f310b Compare December 27, 2025 08:17
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.52%. Comparing base (b56f7d0) to head (28f310b).
⚠️ Report is 40 commits behind head on dev.

Files with missing lines Patch % Lines
anyway/views/user_system/api.py 62.50% 3 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2876      +/-   ##
==========================================
+ Coverage   55.32%   55.52%   +0.19%     
==========================================
  Files         126      128       +2     
  Lines       10783    11321     +538     
==========================================
+ Hits         5966     6286     +320     
- Misses       4817     5035     +218     
Flag Coverage Δ
unittests 55.52% <62.50%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ziv17 ziv17 marked this pull request as ready for review December 28, 2025 14:09
@ziv17 ziv17 requested review from atalyaalon and tkalir December 28, 2025 14:10
@ziv17 ziv17 merged commit 908bc5f into data-for-change:dev Dec 28, 2025
7 of 9 checks passed
@ziv17 ziv17 deleted the 2870-sd-api-fixes branch December 31, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants